-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geyser block-metadata notification with entry count #33359
Add geyser block-metadata notification with entry count #33359
Conversation
6fc2a3f
to
8a62aaa
Compare
Codecov Report
@@ Coverage Diff @@
## master #33359 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 796 796
Lines 215842 215853 +11
=======================================
+ Hits 176910 176921 +11
Misses 38932 38932 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me on geyser side change. I will defer to @carllin on the entry_count is real entry_count in the block.
Looks right! Confirming this is necessary in addition to the existing entry notifications here (which includes the entry index)? solana/ledger/src/blockstore_processor.rs Lines 1148 to 1159 in b5c466d
|
Correct, there's no way for a client to know which entry notification is the expected last one. Technically, there currently exists a way to determine this by tracking all transactions and using the |
…33359) * Add new ReplicaBlockInfoVersions variant * Use new variant to return entry count
…33359) * Add new ReplicaBlockInfoVersions variant * Use new variant to return entry count
Problem
Geyser stream consumers don't know how many entries to expect.
Summary of Changes
Include entry count in block-metadata notification
Fixes #32988