split hash calc ancient slot boundary to allow for ancient shrinking … #33216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33216 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 798 798
Lines 216974 217016 +42
=========================================
+ Hits 177902 177923 +21
- Misses 39072 39093 +21 |
jeffwashington
force-pushed
the
sp16
branch
from
a04df83 to
b21f30c
Compare
jeffwashington
force-pushed
the
sp16
branch
from
b21f30c to
7e7cceb
Compare
brooksprumo
reviewed
Sep 25, 2023
jeffwashington
force-pushed
the
sp16
branch
from
7e7cceb to
ad0cdc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to be behind
Problem
When ancient append vecs are shrinking, we can end up creating far too many chunks of cached hash data files for efficiency. We only want to cache individual append vecs when they are large. The other ones (that we haven't packed yet), we want to cache in slot ranges.
Summary of Changes
Modify the algorithm that splits ancient vs non ancient to ignore 'old' slots that haven't been packed yet (as evidenced by their smaller size).
Fixes #