This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Replicator download test #3320
Merged
sakridge
merged 4 commits into
solana-labs:master
from
sakridge:replicator-download-test
Mar 19, 2019
Merged
Replicator download test #3320
sakridge
merged 4 commits into
solana-labs:master
from
sakridge:replicator-download-test
Mar 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
replicator-download-test
branch
from
March 15, 2019 18:23
db841e2
to
c1054a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3320 +/- ##
========================================
+ Coverage 78.7% 78.8% +0.1%
========================================
Files 153 153
Lines 22080 22187 +107
========================================
+ Hits 17388 17497 +109
+ Misses 4692 4690 -2 |
sagar-solana
approved these changes
Mar 18, 2019
garious
reviewed
Mar 18, 2019
sakridge
force-pushed
the
replicator-download-test
branch
5 times, most recently
from
March 19, 2019 02:20
22b7675
to
7e04adb
Compare
Add optional UdpSocket for storage interface. Add new_localhost_replicator to create a new replicator local node.
sakridge
force-pushed
the
replicator-download-test
branch
from
March 19, 2019 15:08
7e04adb
to
bbe935a
Compare
Add an interface to query the storage slot a replicator is holding on storage_addr port. Fix logic to poll blocktree for all slots replicated being filled. Add test logic to ask replicator what slot it is replicating and then download an entry in the slot.
And rework download loop.
sakridge
force-pushed
the
replicator-download-test
branch
from
March 19, 2019 17:38
bbe935a
to
c0bf356
Compare
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this pull request
Oct 28, 2024
This reverts commit ed5e30d.
ryoqun
pushed a commit
to ryoqun/solana
that referenced
this pull request
Nov 23, 2024
This reverts commit ed5e30d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Nothing testing that replicator can download ledger and also serve to others. Also, a replicator kind of looks like a validator on gossip, but it can't really respond to RPC requests, or use its TPU ports or do things that fullnodes can.
Summary of Changes
Clear out the TPU/RPC ports for replicators and fill in storage_addr and use it as an interface to query replicator for what ledger segment it has.
Add the test logic to find the replicator on gossip and ask it for the segment it's storing.
Fixes #