Transient accounts hash cache dir is unnecessary #33181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
accounts-hash-cache/transient
branch
from
501abb4 to
1246025
Compare
brooksprumo
added
work in progress
Codecov Report
@@ Coverage Diff @@
## master #33181 +/- ##
=========================================
- Coverage 82.1% 81.9% -0.2%
=========================================
Files 786 789 +3
Lines 211606 213444 +1838
=========================================
+ Hits 173812 174962 +1150
- Misses 37794 38482 +688 |
brooksprumo
force-pushed
the
accounts-hash-cache/transient
branch
from
1246025 to
51bdb36
Compare
brooksprumo
added
CI
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
(cherry picked from commit c61ee20) # Conflicts: # runtime/src/accounts_db.rs
brooksprumo
added a commit
that referenced
this pull request
Sep 13, 2023
brooksprumo
added a commit
that referenced
this pull request
Sep 14, 2023
…33181) (#33221) Co-authored-by: Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We create a subdirectory within the accounts hash cache path to hold transient files created while performing the accounts hash calculation. These files are temporary and unnamed, and are not visible by a user looking at the filesystem, so a persistent user-visible directory is not necessary.
Summary of Changes
Remove the persistent transient accounts hash cache dir; instead create a temp dir.