Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove coupling of ShrinkCandidates to HashMap #33176

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

Working on improving startup time.
ShrinkCandidates is a type. The type is currently HashMap. Many places in code use
let v = ShrinkCandidates: HashMap::new()

Summary of Changes

replace with:
let v = ShrinkCandidates::new()
to decouple the types.

Fixes #

@jeffwashington jeffwashington force-pushed the sp7 branch 4 times, most recently from 11ed144 to 23815a5 Compare September 7, 2023 15:06
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #33176 (4f2df57) into master (528a03f) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #33176     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         785      785             
  Lines      211205   211205             
=========================================
- Hits       173444   173426     -18     
- Misses      37761    37779     +18     

@jeffwashington jeffwashington merged commit e331275 into solana-labs:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants