Moves CacheHashData test-only methods into tests module #33170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
cache-hash-data/load
branch
from
05e71da to
b4d9a0a
Compare
brooksprumo
changed the title
brooksprumo
force-pushed
the
cache-hash-data/load
branch
from
b4d9a0a to
82969ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #33170 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 785 785
Lines 211122 211204 +82
=======================================
+ Hits 173328 173396 +68
- Misses 37794 37808 +14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CacheHashData::load()andload_map()are only used withincache_hash_data.rs's tests, but they live outside the tests module.Summary of Changes
Move the methods into the tests module.