Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove -f from cargo install rustfilt #33143

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

yihau
Copy link
Member

@yihau yihau commented Sep 5, 2023

Problem

https://discord.com/channels/428295358100013066/560503042458517505/1148390601335779398

we can't install rustfilt with rust 1.60.0 anymore 😢

Summary of Changes

remove the -f flag so that we can avoid installing it trickily.

@yihau yihau added v1.14 v1.16 PRs that should be backported to v1.16 labels Sep 5, 2023
@yihau yihau requested a review from dmakarov September 5, 2023 15:50
@yihau yihau merged commit 3a91d3c into solana-labs:master Sep 5, 2023
@yihau yihau deleted the remove-f branch September 5, 2023 17:20
mergify bot pushed a commit that referenced this pull request Sep 5, 2023
(cherry picked from commit 3a91d3c)

# Conflicts:
#	sdk/cargo-build-sbf/tests/crates.rs
mergify bot pushed a commit that referenced this pull request Sep 5, 2023
mergify bot added a commit that referenced this pull request Sep 5, 2023
…#33148)

ci: remove -f from cargo install rustfilt (#33143)

(cherry picked from commit 3a91d3c)

Co-authored-by: Yihau Chen <[email protected]>
mergify bot added a commit that referenced this pull request Sep 6, 2023
…#33147)

* ci: remove -f from cargo install rustfilt (#33143)

(cherry picked from commit 3a91d3c)

# Conflicts:
#	sdk/cargo-build-sbf/tests/crates.rs

* fix conflict

* fix conflict

---------

Co-authored-by: Yihau Chen <[email protected]>
Co-authored-by: yihau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.16 PRs that should be backported to v1.16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants