Validator CLI can specify accounts hash cache path #33117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
work in progress
brooksprumo
force-pushed
the
accounts-hash-cache-dir/cli
branch
from
9de5168 to
4d27c5a
Compare
brooksprumo
added
CI
brooksprumo
added
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2023
(cherry picked from commit 88d3c8c) # Conflicts: # validator/src/main.rs
t-nelson
reviewed
Sep 2, 2023
| let accounts_hash_cache_path = matches | ||
| .value_of("accounts_hash_cache_path") | ||
| .map(Into::into) | ||
| .unwrap_or_else(|| ledger_path.join(AccountsDb::DEFAULT_ACCOUNTS_HASH_CACHE_DIR)); |
There was a problem hiding this comment.
the help makes no mention of a default
There was a problem hiding this comment.
What would be the preferred way to indicate the default?
There was a problem hiding this comment.
since we can't resolve the path at help generation time, something like...
format!("[default: LEDGER_DIR/{}]", AccountsDb::DEFAULT_ACCOUNTS_HASH_CACHE_DIR)at the end of the help message
t-nelson
pushed a commit
that referenced
this pull request
Sep 2, 2023
(cherry picked from commit 88d3c8c)
t-nelson
pushed a commit
that referenced
this pull request
Sep 2, 2023
(cherry picked from commit 88d3c8c)
mergify bot
added a commit
that referenced
this pull request
Sep 2, 2023
…#33117) (#33127) Validator CLI can specify accounts hash cache path (#33117) (cherry picked from commit 88d3c8c) Co-authored-by: Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The accounts hash cache is stored in the ledger directory, and does not have a way for a node operator to move it. Since the accounts hash cache has a decent amount of I/O, if a disk is overwhelmed, there's no way to move the accounts hash cache somewhere else.
Summary of Changes
Add a CLI arg,
--accounts-hash-cache-path, tosolana-validatorto specify the accounts hash cache path.