Handle closing of the program in the same slot as deployment #33025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
approved these changes
Aug 28, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit e036a03)
mergify bot
added a commit
that referenced
this pull request
Aug 28, 2023
…backport of #33025) (#33027) Handle closing of the program in the same slot as deployment (#33025) (cherry picked from commit e036a03) Co-authored-by: Pankaj Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The cache retains the deployed program even though it was closed, if the deployment and close happened in the same slot.
Summary of Changes
The tombstone for closed program was not getting inserted in the cache. This allowed the cached entry for the deployed program to remain active. This PR checks if the new entry is a tombstone, and inserts it in the cache.
Fixes #