Fix - Reordering in second level index of LoadedPrograms #32973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
added
bug
ryoqun
approved these changes
Aug 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #32973 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 784 784
Lines 212650 212650
=======================================
+ Hits 174379 174393 +14
+ Misses 38271 38257 -14 |
pgarg66
approved these changes
Aug 24, 2023
Lichtso
deleted the
fix/reordering_in_second_level_index_of_loaded_programs
branch
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
Replaces "swap_remove" => "remove". (cherry picked from commit 3bd14cc)
Lichtso
added a commit
that referenced
this pull request
Aug 24, 2023
…port of #32973) (#32977) Fix - Reordering in second level index of LoadedPrograms (#32973) Replaces "swap_remove" => "remove". (cherry picked from commit 3bd14cc) Co-authored-by: Alexander Meißner <[email protected]>
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
swap_removecan disturb the assumptions about the ordering of entries in the second level index ofLoadedPrograms.Summary of Changes
Replaces
swap_remove=>remove