Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

v1.16: tpu-client: Speed up performance by awaiting all futures at once (backport of #32945) #32972

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 24, 2023

This is an automatic backport of pull request #32945 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

)

* tpu-client: Await all futures at once

* Add timeout when sending to not waste time on down nodes

* Update comment to make it clearer that we're not spiking

(cherry picked from commit b42249f)
@joncinque joncinque requested a review from KirillLykov August 24, 2023 11:38
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #32972 (01f0bf4) into v1.16 (9b06ca8) will decrease coverage by 0.1%.
The diff coverage is 93.0%.

@@            Coverage Diff            @@
##            v1.16   #32972     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         762      762             
  Lines      208055   208078     +23     
=========================================
+ Hits       170581   170584      +3     
- Misses      37474    37494     +20     

@joncinque joncinque merged commit f1100ba into v1.16 Aug 25, 2023
@joncinque joncinque deleted the mergify/bp/v1.16/pr-32945 branch August 25, 2023 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants