ff cleanup: vote_state_update_credit_per_deque #32966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
commented
Aug 23, 2023
| @@ -549,7 +549,7 @@ pub fn process_new_vote_state( | |||
| new_root: Option<Slot>, | |||
| timestamp: Option<i64>, | |||
| epoch: Epoch, | |||
| feature_set: Option<&FeatureSet>, | |||
| _feature_set: Option<&FeatureSet>, | |||
There was a problem hiding this comment.
intentionally leaving this here because the upcoming timely vote credits change will need it
Codecov Report
@@ Coverage Diff @@
## master #32966 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 784 784
Lines 212715 212709 -6
=========================================
- Hits 174426 174370 -56
- Misses 38289 38339 +50 |
AshwinSekar
force-pushed
the
ff-cleanup-vote-credit
branch
from
f5f2ec6 to
6c6f98b
Compare
AshwinSekar
force-pushed
the
ff-cleanup-vote-credit
branch
from
6c6f98b to
a29af96
Compare
carllin
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activated mainnet 491.
Fixes #27091