Implement timely vote credits feature. #32957
Conversation
| // can be in this set are those oldest slots in the current vote state that are not present in the | ||
| // new vote state; these have been "popped off the back" of the tower and thus represent finalized slots | ||
| let mut finalized_slot_count = 1_u64; | ||
| // Accumulate credits earned by newly rooted slots. The behavior changes with timely_vote_credits: prior to |
There was a problem hiding this comment.
Here's the updated comment for the additional credits accounting fix.
| let timely_vote_credits = feature_set.map_or(false, |f| { | ||
| f.is_active(&feature_set::timely_vote_credits::id()) | ||
| }); | ||
| let mut earned_credits = if timely_vote_credits { 0_u64 } else { 1_u64 }; |
There was a problem hiding this comment.
Lines 616-619 are changed from the original timely_vote_credits submission as part of the credits accounting fix.
|
|
||
| if let Some(new_root) = new_root { | ||
| for current_vote in &vote_state.votes { | ||
| // Find the first vote in the current vote state for a slot greater | ||
| // than the new proposed root | ||
| if current_vote.slot() <= new_root { | ||
| if timely_vote_credits || (current_vote.slot() != new_root) { |
There was a problem hiding this comment.
This conditional is added as part of the credits accounting fix.
|
I have added comments to the sections that were changed from the original timely_vote_credits change. These are the only differences with that original PR, otherwise this PR is identical to the timely_vote_credits change already accepted (I authored this new change with: |
Codecov Report
@@ Coverage Diff @@
## master #32957 +/- ##
========================================
Coverage 82.1% 82.1%
========================================
Files 786 786
Lines 211634 211880 +246
========================================
+ Hits 173794 174036 +242
- Misses 37840 37844 +4 📢 Have feedback on the report? Share it here. |
bji
force-pushed
the
timely_vote_credits_2_plus_fix
branch
2 times, most recently
from
e02824b to
ff23b22
Compare
bji
force-pushed
the
timely_vote_credits_2_plus_fix
branch
from
ff23b22 to
0df05a9
Compare
|
Currently running this against mnb, will approve if there are no issues over the weekend |
Re-submission of the timely_vote_credits feature, with a guard around credits accounting to ensure that credit counting is not altered before the feature is enabled.