Refactor - LoadedPrograms::get_entries_sorted_by_tx_usage()
#32874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
pgarg66
approved these changes
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #32874 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 785 785
Lines 212412 212418 +6
=======================================
+ Hits 174212 174234 +22
+ Misses 38200 38184 -16 |
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 21, 2023
…-labs#32874) Factor get_entries_sorted_by_tx_usage() out of sort_and_unload().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR was split from #32172.
At the moment only
LoadedPrograms::sort_and_unload()uses the sorted list of verified and compiled programs to evict them, but the recompilation phase before epoch boundaries will soon need that as well.Summary of Changes
Adds
LoadedPrograms::get_entries_sorted_by_tx_usage()which returns the list of loaded programs which are verified and compiled sorted bytx_usage_counterand can filter the result depending on the selected program runtime versions.