Refactor - Bank::compute_active_feature_set()
#32872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmakarov Wanted to add labels, accidentally removed a reviewer. Please ignore, and proceed with the review. |
dmakarov
reviewed
Aug 17, 2023
runtime/src/bank.rs
Outdated
| @@ -7982,7 +7984,10 @@ impl Bank { | |||
| } | |||
|
|
|||
| // Compute the active feature set based on the current bank state, and return the set of newly activated features | |||
There was a problem hiding this comment.
it seems the comment becomes outdated by the change, doesnt' it?
…e_active_feature_set().
Lichtso
force-pushed
the
refactor/bank_compute_active_feature_set
branch
from
a03fc32 to
c66c76a
Compare
|
LGTM. |
pgarg66
approved these changes
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #32872 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 785 785
Lines 212412 212412
=======================================
+ Hits 174212 174261 +49
+ Misses 38200 38151 -49 |
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 21, 2023
Returns the feature set instead of overwriting it inside Bank::compute_active_feature_set().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR was split from #32172.
Currently
Bank::compute_active_feature_set()does not just compute the active feature set as the name implies, but also writes the result back intoself.Summary of Changes
Bank::compute_active_feature_set()now returns the new feature set and the difference to the current one. The overwriting ofself.feature_setwas factored out into the call sites.