Fixup duplicate shred proof plumbing #32862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
force-pushed
the
duplicate-shred-proof
branch
3 times, most recently
from
22600b5 to
6c94e92
Compare
AshwinSekar
force-pushed
the
duplicate-shred-proof
branch
from
6c94e92 to
40cb061
Compare
|
this is kinda large to review. description implies that there may be an opportunity to split it into (at least) three isolated PRs. possible? |
|
will split this up as suggested. |
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Duplicate shreds detected due to invalid
LAST_SHRED_IN_SLOTflags, or erasure metas are stored in blockstore but never forwarded to the cluster or the state machine.Similarly duplicate shreds received through gossip are never forwarded to the state machine.
Also on replay from ledger, we do not do anything with the blockstore cf indicating duplicate proof, this should be sent to the state machine.
Summary of Changes
Fix the plumbing.
Fixes #