asserts that socket addresses set in new_with_external_ip are valid #32860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new_with_external_ip silently ignores errors when setting socket addresses which makes it harder to catch bugs: https://github.com/solana-labs/solana/blob/7beeb8310/gossip/src/cluster_info.rs#L3054-L3063
Codecov Report
@@ Coverage Diff @@
## master #32860 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 785 785
Lines 212149 212149
=======================================
+ Hits 174016 174042 +26
+ Misses 38133 38107 -26 |
gregcusack
approved these changes
Aug 16, 2023
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 21, 2023
…olana-labs#32860) new_with_external_ip silently ignores errors when setting socket addresses which makes it harder to catch bugs: https://github.com/solana-labs/solana/blob/7beeb8310/gossip/src/cluster_info.rs#L3054-L3063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
new_with_external_ipsilently ignores errors when setting socket addresses which makes it harder to catch bugs:https://github.com/solana-labs/solana/blob/7beeb8310/gossip/src/cluster_info.rs#L3054-L3063
Summary of Changes
assert that socket addresses set in
new_with_external_ipare valid.