Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add active stats for pieces of hash calc #32750

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

accounts hash algorithm is a constant concern for cpu, memory, and disk i/o performance. There are 3 distinct phases: scan, dedup, merkle tree.

Summary of Changes

Add a stat reporting which part of the algorithm is active. This allows correlation with i/o, mem usage, etc.

Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review August 7, 2023 22:24
@jeffwashington jeffwashington requested a review from HaoranYi August 7, 2023 22:24
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #32750 (4b55e7b) into master (5c86f89) will increase coverage by 0.0%.
Report is 6 commits behind head on master.
The diff coverage is 93.1%.

@@           Coverage Diff            @@
##           master   #32750    +/-   ##
========================================
  Coverage    82.0%    82.0%            
========================================
  Files         785      785            
  Lines      211193   211465   +272     
========================================
+ Hits       173190   173422   +232     
- Misses      38003    38043    +40     

@jeffwashington jeffwashington merged commit 7c1cf29 into solana-labs:master Aug 8, 2023
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants