Removes set_no_remove_on_drop() from AppendVec/AccountsFile
#32742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32742 +/- ##
=========================================
- Coverage 82.0% 81.9% -0.1%
=========================================
Files 785 785
Lines 211192 211175 -17
=========================================
- Hits 173200 173149 -51
- Misses 37992 38026 +34 |
brooksprumo
force-pushed
the
remove-on-drop/method
branch
from
d7fda30 to
47e1718
Compare
yhchiang-sol
approved these changes
Aug 7, 2023
Comment on lines
-61
to
-69
| /// By default, all AccountsFile will remove its underlying file on | ||
| /// drop. Calling this function to disable such behavior for this | ||
| /// instance. | ||
| pub fn set_no_remove_on_drop(&mut self) { | ||
| match self { | ||
| Self::AppendVec(av) => av.set_no_remove_on_drop(), | ||
| } | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
set_no_remove_on_drop()method on AppendVec and AccountsFile is unused (and should not be used). It should be removed.Summary of Changes
Remove the methods.