Do not drop AppendVec in store-tool #32739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The store-tool should remove cause the backing storage of the AppendVec it inspects to be removed. Currently, that's accomplished via toggling the
AppendVec::remove_on_drop
field. Now that Rust hasManuallyDrop
, we can (i.e. should) use that instead.Summary of Changes
Use ManuallyDrop to not remove the backing store.
Miscellaneous
Here's an example of using
ManuallyDrop
, create a wrapper to not drop, and then another wrapper than can drop. Useful ifManuallyDrop
is new-to-you: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c5322f69ab160d2d557162f6c325a29e