Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

improve prioritization fee cache accuracy #32692

Merged

Conversation

tao-stones
Copy link
Contributor

@tao-stones tao-stones commented Aug 2, 2023

Problem

Prioritization fee cache accuracy can be improved.

Summary of Changes

  • moved cache's finalization from "bank replayed" to "bank opt-confirmed"

Fixes #

@tao-stones tao-stones force-pushed the prioritization_fee_finalization branch from 09c4ab8 to 7eadd00 Compare August 2, 2023 17:51
@tao-stones tao-stones added v1.14 v1.16 PRs that should be backported to v1.16 labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #32692 (07d4ecb) into master (67b2f89) will increase coverage by 0.0%.
Report is 36 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #32692   +/-   ##
=======================================
  Coverage    82.0%    82.0%           
=======================================
  Files         785      785           
  Lines      211067   211113   +46     
=======================================
+ Hits       173151   173192   +41     
- Misses      37916    37921    +5     

CriesofCarrots
CriesofCarrots previously approved these changes Aug 4, 2023
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good to me! r+ fixing up Arcs

rpc/src/optimistically_confirmed_bank_tracker.rs Outdated Show resolved Hide resolved
@tao-stones tao-stones requested a review from apfitzge August 7, 2023 23:31
@tao-stones tao-stones merged commit ef6af30 into solana-labs:master Aug 8, 2023
@tao-stones tao-stones deleted the prioritization_fee_finalization branch August 8, 2023 00:27
mergify bot pushed a commit that referenced this pull request Aug 8, 2023
* improve prioritization cache accuracy

(cherry picked from commit ef6af30)

# Conflicts:
#	rpc/src/optimistically_confirmed_bank_tracker.rs
mergify bot pushed a commit that referenced this pull request Aug 8, 2023
* improve prioritization cache accuracy

(cherry picked from commit ef6af30)
tao-stones added a commit that referenced this pull request Aug 8, 2023
* improve prioritization cache accuracy

(cherry picked from commit ef6af30)

fix merge conflict
tao-stones added a commit that referenced this pull request Aug 8, 2023
* improve prioritization cache accuracy

(cherry picked from commit ef6af30)

fix merge conflict
tao-stones added a commit that referenced this pull request Aug 8, 2023
* improve prioritization cache accuracy

(cherry picked from commit ef6af30)

fix merge conflict
tao-stones added a commit that referenced this pull request Aug 8, 2023
…#32755)

improve prioritization fee cache accuracy (#32692)

* improve prioritization cache accuracy

(cherry picked from commit ef6af30)

fix merge conflict

Co-authored-by: Tao Zhu <[email protected]>
tao-stones added a commit that referenced this pull request Aug 8, 2023
…#32756)

improve prioritization fee cache accuracy (#32692)

* improve prioritization cache accuracy

(cherry picked from commit ef6af30)

Co-authored-by: Tao Zhu <[email protected]>
bw-solana pushed a commit to bw-solana/solana that referenced this pull request Jan 10, 2025
…labs#32692) (solana-labs#32755)

improve prioritization fee cache accuracy (solana-labs#32692)

* improve prioritization cache accuracy

(cherry picked from commit ef6af30)

fix merge conflict

Co-authored-by: Tao Zhu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v1.16 PRs that should be backported to v1.16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants