Removes old accounts hash cache dir #32604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32604 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 781 781
Lines 210801 210813 +12
=========================================
- Hits 172959 172947 -12
- Misses 37842 37866 +24 |
t-nelson
approved these changes
Jul 24, 2023
| // The accounts hash cache dir was renamed, so cleanup the old dir if it exists. | ||
| let old_accounts_hash_cache_dir = ledger_path.join("calculate_accounts_hash_cache"); | ||
| if old_accounts_hash_cache_dir.exists() { | ||
| snapshot_utils::move_and_async_delete_path(old_accounts_hash_cache_dir); |
There was a problem hiding this comment.
unrelated: logic in here looks a little suspect 🤔
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
(cherry picked from commit 36b3722)
brooksprumo
added a commit
that referenced
this pull request
Jul 25, 2023
(cherry picked from commit 36b3722)
brooksprumo
added a commit
that referenced
this pull request
Jul 25, 2023
Removes old accounts hash cache dir (#32604) (cherry picked from commit 36b3722) Co-authored-by: Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The directory that caches the result from accounts hash calculation was renamed in #29734. This required manual intervention on the part of node operators to remove the old cache directory. While it was harmless, the old directory did take up disk space. It should be cleaned up automatically.
Summary of Changes
Remove the old cache dir, if it exists.