Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stake flags struct #32521

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Add stake flags struct #32521

merged 1 commit into from
Jul 18, 2023

Conversation

HaoranYi
Copy link
Contributor

Problem

Fix a stake redelegation issue.

Part of #31876

Summary of Changes

Add stake_flag struct

Fixes #

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #32521 (99dd2e1) into master (c69bc00) will increase coverage by 0.0%.
The diff coverage is 72.7%.

@@           Coverage Diff           @@
##           master   #32521   +/-   ##
=======================================
  Coverage    82.0%    82.0%           
=======================================
  Files         779      780    +1     
  Lines      210609   210664   +55     
=======================================
+ Hits       172742   172817   +75     
+ Misses      37867    37847   -20     

@HaoranYi HaoranYi requested review from joncinque, t-nelson, mvines and 2501babe and removed request for joncinque July 18, 2023 15:34
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! splitting the other pr into multiple commits would've been fine as well. only really necessary to ease review. namely moving the flag plumbing out on its own so functional changes are clear.

this works too though! 🙏

@HaoranYi HaoranYi merged commit 88c52a5 into solana-labs:master Jul 18, 2023
@HaoranYi HaoranYi deleted the stake_flags branch July 18, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants