deprecates Signature::new in favor of Signature::{try_,}from #32481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signature::new lacks type-safety and may panic. The commit deprecates
this interface and instead implements Signature::{try_,}from.
Codecov Report
@@ Coverage Diff @@
## master #32481 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 778 778
Lines 210199 210192 -7
=======================================
+ Hits 172616 172628 +12
+ Misses 37583 37564 -19 |
t-nelson
reviewed
Jul 13, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit cfb0288) # Conflicts: # perf/src/sigverify.rs
willhickey
pushed a commit
that referenced
this pull request
Jul 18, 2023
(cherry picked from commit cfb0288) # Conflicts: # perf/src/sigverify.rs
mergify bot
added a commit
that referenced
this pull request
Jul 18, 2023
…backport of #32481) (#32510) * deprecates Signature::new in favor of Signature::{try_,}from (#32481) (cherry picked from commit cfb0288) # Conflicts: # perf/src/sigverify.rs * resolves mergify merge conflicts --------- Co-authored-by: behzad nouri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Signature::newlacks type-safety and may panic.Summary of Changes
The commit deprecates this interface and instead implements
Signature::{try_,}from.