Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup impl for remove_tmp_snapshot_archives() #32297

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

The impl for snapshot_utils::remove_tmp_snapshot_archives() is a bit sus w.r.t. checking if the file name indicates a tmp snapshot archive that should be removed.

Originally brought up in a previous PR here: #32286 (comment)

Summary of Changes

Un-sus it.

@brooksprumo brooksprumo self-assigned this Jun 27, 2023
@brooksprumo brooksprumo marked this pull request as ready for review June 27, 2023 17:37
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #32297 (fc8ce55) into master (13aff74) will increase coverage by 0.0%.
The diff coverage is n/a.

❗ Current head fc8ce55 differs from pull request most recent head 06f9fa7. Consider uploading reports for the commit 06f9fa7 to get more accurate results

@@           Coverage Diff           @@
##           master   #32297   +/-   ##
=======================================
  Coverage    82.0%    82.0%           
=======================================
  Files         772      772           
  Lines      209524   209524           
=======================================
+ Hits       171985   172007   +22     
+ Misses      37539    37517   -22     

@brooksprumo brooksprumo requested a review from apfitzge June 27, 2023 18:13
@brooksprumo brooksprumo requested a review from apfitzge June 27, 2023 19:01
@brooksprumo brooksprumo merged commit 9fb105c into solana-labs:master Jun 27, 2023
@brooksprumo brooksprumo deleted the snap/cleanup branch June 27, 2023 19:51
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants