-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: only kill containers that are based on the solanalabs/rust* images #32292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just nits
on another note, seems like everything in this hook is hacks around behavior that we should try to correct?
Co-authored-by: Trent Nelson <[email protected]>
Co-authored-by: Trent Nelson <[email protected]>
yeah! I separate this script into 1) process killing and 2) cargo uninstall for 1) I would like to just remove them and see do we encounter issues. these codes are added like 4y ago. maybe buildkite has already those issues 🤔 for 2) I guess I can remove them when the migration finish! |
🙌
if i had to guess this is more likely to be hung tests not responding to the kill signal than some bk problem
probably. the problem isn't exactly clear from the comment. i get how cargo uses CARGO_HOME, but not what the conflict is that makes us want to uninstall these bins by force. worst case seem like the solution would be to install them in a custom dir and control that dir's priority in PATH 🤷 |
#32292) * ci: only kill containers that are based on the solanalabs/rust* images * Update .buildkite/hooks/post-checkout Co-authored-by: Trent Nelson <[email protected]> * Update .buildkite/hooks/post-checkout Co-authored-by: Trent Nelson <[email protected]> * fix lint --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 3e5ee8d) # Conflicts: # .buildkite/hooks/post-checkout
#32292) * ci: only kill containers that are based on the solanalabs/rust* images * Update .buildkite/hooks/post-checkout Co-authored-by: Trent Nelson <[email protected]> * Update .buildkite/hooks/post-checkout Co-authored-by: Trent Nelson <[email protected]> * fix lint --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 3e5ee8d)
…* images (backport of #32292) (#32325) * ci: only kill containers that are based on the solanalabs/rust* images (#32292) * ci: only kill containers that are based on the solanalabs/rust* images * Update .buildkite/hooks/post-checkout Co-authored-by: Trent Nelson <[email protected]> * Update .buildkite/hooks/post-checkout Co-authored-by: Trent Nelson <[email protected]> * fix lint --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 3e5ee8d) # Conflicts: # .buildkite/hooks/post-checkout * fix conflict --------- Co-authored-by: Yihau Chen <[email protected]> Co-authored-by: yihau <[email protected]>
…* images (backport of #32292) (#32326) ci: only kill containers that are based on the solanalabs/rust* images (#32292) * ci: only kill containers that are based on the solanalabs/rust* images * Update .buildkite/hooks/post-checkout Co-authored-by: Trent Nelson <[email protected]> * Update .buildkite/hooks/post-checkout Co-authored-by: Trent Nelson <[email protected]> * fix lint --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 3e5ee8d) Co-authored-by: Yihau Chen <[email protected]>
Problem
I'm trying to migrate our ci environment into a single docker image. Kill all containers will kill the buildkite process as well. Also it seems too aggressive to kill all containers in the machine.
Summary of Changes
only kill containers that are based on the
solanalabs/rust*
images.