Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bench tps tx account limits #32281
Bench tps tx account limits #32281
Changes from all commits
d52c56d
1b72ff9
3648df7
05c320f
75feb6e
9d07813
83cea1b
49b9ac6
66d3f18
e3d3133
3925d10
f9d9a48
de7f6fa
b57cc4e
9a82149
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this might fail often enough if we use testnet or similar. In this case we need to implement some error handling strategy (try again for example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's gotta be a better way than this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps. Didn't feel this is more important than funding txs where it also sleeps for a sec between sending batch of transactions and verifying them (send_batch.rs: Ln227). Just just copied it ;)
Can use a timeout loop to call
get_account_with_commiment()
withms
sleep in between to reduce overall wait time. Don't fee that makes meaningful difference tho.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we believe that verifying that accounts has been added properly is necessary, I would do this on the level up: request accounts from ALT and check that at least the number of accounts as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original intention is to first confirm the ALT account was created before sending extend transactions, not so much about the number of accounts were added to the ATL. so it just did account lookup, which is sufficient imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a mixed feeling about that part, I think it would be more efficient to extend ALTs and after that do the check in a separate loop. Another thing is that the check requires
trace
and also usingunwrap
. My experience with testnet is that all transactions from time to time fail or go to the block much later than has been sent.