correct feature gate use_default_units_in_fee_calculation usage

[tao-stones]

Problem

Noticed the misusage of feature gate use_default_units_in_fee_calculation when working on another issue. This feature gate (#26785) was introduced to fix a hard-coded bug in bank::calculate_fee(), should only be used when calling calculate_fee().

default_units_per_instruction was enabled in mnb in epoch 327, all calls to ComputeBudget::process_instructions() should pass true to this parameter.

The misusage corrected in this PR most likely resulting from copy/paste. Correcting should not have functional impact.

Summary of Changes

• use true for default_units_per_instruction instead of using wrong feature gate status.

Fixes #

[codecov]

Codecov Report

Merging #32077 (4dcd8fc) into master (0645e96) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #32077     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         765      765             
  Lines      208477   208475      -2     
=========================================
- Hits       170895   170861     -34     
- Misses      37582    37614     +32     

[apfitzge]

Changes looks good to me. Bug was introduced in #30506, thanks for catching this quickly!

[tao-stones]

Changes looks good to me. Bug was introduced in #30506, thanks for catching this quickly!

I wonder if it was introduced much earlier, probably here.