Add runtime environment to FailedVerification tombstones #31991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In |
Codecov Report
@@ Coverage Diff @@
## master #31991 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 762 762
Lines 207641 207660 +19
=======================================
+ Hits 170074 170100 +26
+ Misses 37567 37560 -7 |
pgarg66
force-pushed
the
failed-verify-env
branch
from
58675b8 to
e6628bc
Compare
Lichtso
approved these changes
Jun 6, 2023
pgarg66
added
v1.16
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
* Add runtime environment to FailedVerification tombstones * modify default variant * prune update * add DelayVisibility in prune_feature_set_transition (cherry picked from commit c86e160)
mergify bot
added a commit
that referenced
this pull request
Jun 6, 2023
…port of #31991) (#32001) Add runtime environment to FailedVerification tombstones (#31991) * Add runtime environment to FailedVerification tombstones * modify default variant * prune update * add DelayVisibility in prune_feature_set_transition (cherry picked from commit c86e160) Co-authored-by: Pankaj Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The programs that failed verification could succeed after a certain runtime feature has been activated. Currently, cache does not store the runtime environment that was used when the program failed to verify/compile. It's needed to check if the re-verification should be triggered for the failed program.
Summary of Changes
Retain environment for FailedVerification tombstones.
Fixes #