use one definition of builtin program cost in runtime and banking stage #31930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
commented
Jun 2, 2023
| (feature::id(), COMPUTE_UNIT_TO_US_RATIO * 2), | ||
| (incinerator::id(), COMPUTE_UNIT_TO_US_RATIO * 2), | ||
| (native_loader::id(), COMPUTE_UNIT_TO_US_RATIO * 2), | ||
| (solana_sdk::stake::config::id(), COMPUTE_UNIT_TO_US_RATIO * 2), |
There was a problem hiding this comment.
above four entries are not programs, ref #30639 (comment)
tao-stones
commented
Jun 2, 2023
|
|
||
| declare_process_instruction!( | ||
| process_instruction, | ||
| DEFAULT_COMPUTE_UNITS, |
There was a problem hiding this comment.
the actual changes to this, and other programs, is add and use DEFAULT_COMPUTE_UNITS instead of a number (eg 750). But the rustfmt rearranged large chunk of code.
Codecov Report
@@ Coverage Diff @@
## master #31930 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 759 759
Lines 207250 207243 -7
=========================================
- Hits 169807 169790 -17
- Misses 37443 37453 +10 |
Lichtso
reviewed
Jun 2, 2023
Lichtso
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
builtin programs compute units are defined in two places: runtime/src/block_cost_limits.rs and at runtime for each program. This potentially introduces inconsistency. Should define builtin program's CU at one place.
Summary of Changes
pub const DEFAULT_COMPUTE_UNITSfor each program,Fixes #