Evict program cache using transaction usage counter #31927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
reviewed
Jun 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #31927 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 759 759
Lines 207208 207245 +37
=======================================
+ Hits 169720 169792 +72
+ Misses 37488 37453 -35 |
Lichtso
approved these changes
Jun 2, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
* Evict program cache using tx usage counter * address review feedback * address review feedback (cherry picked from commit 37ebb70)
mergify bot
added a commit
that referenced
this pull request
Jun 2, 2023
#31927) (#31952) Evict program cache using transaction usage counter (#31927) * Evict program cache using tx usage counter * address review feedback * address review feedback (cherry picked from commit 37ebb70) Co-authored-by: Pankaj Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The program usage counter is based on usage in instructions. This causes programs to get evicted/unloaded which are referenced in a transaction, but not called by an instruction. This results into unnecessary unloading/reloading of such programs.
Summary of Changes
Fixes #