-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup - Various feature gates #31750
Cleanup - Various feature gates #31750
Conversation
14f4280
to
e9d8885
Compare
Doing this all in one PR seems like a bad idea to me |
I can spit it up if you like, but opening 14 PRs did not seem so good either. |
f3ba505
to
62158ad
Compare
I feel separate PRs is the way to go as well. I understand the pain, I know it'll take longer, etc. Reviews for each 14 PR should be pretty obvious though, certainly should tag the original feature-gate author for that review too. |
62158ad
to
8c3ed89
Compare
Yeah, what Michael said. Unless any of them are too intertwined with each other, I am in favor of 14 different PRs |
8c3ed89
to
21e185e
Compare
Ok, let me just get this PR through CI, then I will close it and reopen as split PRs. |
21e185e
to
dc05854
Compare
548539f
to
da22ebe
Compare
da22ebe
to
d687bb8
Compare
d687bb8
to
e95f530
Compare
Codecov Report
@@ Coverage Diff @@
## master #31750 +/- ##
========================================
Coverage 81.8% 81.8%
========================================
Files 736 736
Lines 205955 205733 -222
========================================
- Hits 168631 168495 -136
+ Misses 37324 37238 -86 |
Problem
Since epoch 321 (almost a year ago) various features were activated (on all three clusters) but their feature gating logic was never cleaned up.
Summary of Changes
Removes feature gating logic of the following features: