Use generics for add/remove subscriptions #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
approved these changes
Mar 7, 2019
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #3175 +/- ##
========================================
+ Coverage 80.8% 80.9% +<.1%
========================================
Files 129 129
Lines 19497 19491 -6
========================================
- Hits 15770 15769 -1
+ Misses 3727 3722 -5 |
Codecov Report
@@ Coverage Diff @@
## master #3175 +/- ##
========================================
+ Coverage 80.8% 80.9% +<.1%
========================================
Files 129 129
Lines 19497 19491 -6
========================================
- Hits 15770 15769 -1
+ Misses 3727 3722 -5 |
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Oct 15, 2024
* fix doc link in solana-epoch-schedule * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Irritating copy-pasta in makes it difficult to add a new rpc subscription type
Summary of Changes
Make helper functions using generics as needed