Remove Rc and RefCell to carry program cache in invoke_context #31684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
simplify-cache-container
branch
from
807694c
to
042ad73
Compare
Codecov Report
@@ Coverage Diff @@
## master #31684 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 737 737
Lines 205972 205954 -18
=========================================
- Hits 168739 168650 -89
- Misses 37233 37304 +71 |
Lichtso
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
InvokeContextshould not requireRcandRefCellto carry program cache references.Summary of Changes
Clean up the cache references in
InvokeContextand update surrounding code.Fixes #