-
Notifications
You must be signed in to change notification settings - Fork 4.5k
adds code-path broadcasting shreds using QUIC #31610
adds code-path broadcasting shreds using QUIC #31610
Conversation
797d3a8
to
930e90f
Compare
Codecov Report
@@ Coverage Diff @@
## master #31610 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 764 765 +1
Lines 208096 208248 +152
=========================================
+ Hits 170507 170631 +124
- Misses 37589 37617 +28 |
afe4fa1
to
4a29410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, just a few nits and questions. And then the larger question from #31576 about whether this should be included in 1.16. It would be better to include it, but we'll need to start telling operators to start opening the new port immediately.
If it's in 1.16, we'd likely avoid the situation of needing to make a 1.13-style branch just to force Turbine over QUIC. You probably have a clearer plan, but it could look like:
- 1.16: validators open the port and can receive it, helping the 1.16 to 1.17 transition
- 1.17: cut over to only QUIC
- 1.18: shut off UDP
Let me know if I should post this elsewhere
2a5b177
to
01d55fe
Compare
074d714
to
adf56cb
Compare
Working towards migrating turbine to QUIC.
adf56cb
to
944cb26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
how much of this stuff really needs to be in master before we know for a fact that quic is suited for the job? i don't want to be in a situation where we have a bunch of gaps in abi and special-case logic because we got ahead of ourselves and committed code that was doomed to be abandoned |
adds quic connection cache to turbine Working towards migrating turbine to QUIC.
adds quic connection cache to turbine Working towards migrating turbine to QUIC.
adds quic connection cache to turbine Working towards migrating turbine to QUIC.
adds quic connection cache to turbine Working towards migrating turbine to QUIC.
Problem
Turbine => QUIC migration
Summary of Changes