Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize matching criteria for tombstone at boot up #31547

Merged
merged 1 commit into from
May 9, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented May 8, 2023

Problem

The tombstones fail to match at start up while running ledger-tool

Summary of Changes

The criteria to match against closed program is too restrictive. The tombstones were of LoadedProgramType::FailedVerification type. This PR generalizes the check to match against any type of tombstone.

Fixes #

@pgarg66 pgarg66 requested a review from Lichtso May 8, 2023 21:51
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #31547 (7c2c4cb) into master (b20024c) will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##           master   #31547   +/-   ##
=======================================
  Coverage    81.3%    81.3%           
=======================================
  Files         734      734           
  Lines      205284   205284           
=======================================
+ Hits       167077   167084    +7     
+ Misses      38207    38200    -7     

@pgarg66 pgarg66 merged commit 3845423 into solana-labs:master May 9, 2023
@pgarg66 pgarg66 deleted the handle-tombstones-at-start branch May 9, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants