AccountsHashVerifier purges old bank snapshots #31519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We retain more bank snapshots than we need, longer than we need.
Building on #31511, what if a validator turns off generating snapshots? In that case, the node will still take bank snapshots since they are needed for accounts hash verification. Only snapshots intended for archival are turned off (this is the majority though).
In this scenario, we may not clean up old bank snapshots.
This is/will especially be true once AccountsBackgroundService is not in charge of cleaning up old bank snapshots.
In that case, since AccountsHashVerifier is the last one to consume the bank snapshot, it should be the one to clean them up as well.
Summary of Changes
AccountsHashVerifier will purge bank snapshots older than the one that was just processed IFF snapshot (archival) is disabled.