Remove obsolete code for lazily loading programs #31395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
loader-changes
branch
2 times, most recently
from
d6928e3 to
4a134f4
Compare
Codecov Report
@@ Coverage Diff @@
## master #31395 +/- ##
=======================================
Coverage 81.4% 81.4%
=======================================
Files 731 731
Lines 208570 208572 +2
=======================================
+ Hits 169856 169869 +13
+ Misses 38714 38703 -11 |
dmakarov
reviewed
Apr 29, 2023
dmakarov
previously approved these changes
Apr 29, 2023
dmakarov
previously approved these changes
Apr 29, 2023
Lichtso
reviewed
May 1, 2023
pgarg66
commented
May 2, 2023
Lichtso
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
bpf_loaderstill has code to lazily load programs, but its obsolete now. Thebankloads all the programs in a transaction batch before the loader is called. The obsolete code should be removed.Summary of Changes
Removed the obsolete code, and updated the tests.
Fixes #