Spins up AccountsHashVerifier in ledger-tool #31358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
the
feature-gate
brooksprumo
force-pushed
the
eah/ledger-tool-ahv
branch
from
2396d62 to
c13a1ac
Compare
brooksprumo
removed
the
feature-gate
brooksprumo
commented
Apr 26, 2023
Comment on lines
+1271
to
+1276
| let node_id = Arc::new(Keypair::new()); | ||
| let cluster_info = Arc::new(ClusterInfo::new( | ||
| ContactInfo::new_localhost(&node_id.pubkey(), timestamp()), | ||
| Arc::clone(&node_id), | ||
| SocketAddrSpace::Unspecified, | ||
| )); |
There was a problem hiding this comment.
AccountsHashVerifier needs a ClusterInfo to push the accounts hashes to gossip. But since we don't actually care about gossip in ledger-tool, just use default/dummy values.
| None, | ||
| false, | ||
| None, | ||
| SnapshotConfig::new_load_only(), |
There was a problem hiding this comment.
Similarly, we could use the snapshot_config that was created above, but we don't want to create and snapshot archives with AHV here; it's only used to service EAH requests.
Codecov Report
@@ Coverage Diff @@
## master #31358 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 734 734
Lines 207153 207153
=========================================
- Hits 168954 168948 -6
- Misses 38199 38205 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When creating a snapshot with ledger-tool, and when the Epoch Accounts Hash feature-gate is enabled (#27539), ledger-tool will hang if it replays a slot that needs to save an EAH.
This is because the bank at that (☝️) slot needs to wait for the EAH request to be handled and for the EAH to be calculated.
AccountsHashVerifier is where EAH requests are handled, but AHV is not spun up for ledger-tool. This means that all ledger-tool commands that replay slots (like
verifyandcreate-snapshot) that cross an EAH boundary will hang waiting for a valid EAH that will never be.Summary of Changes
Spin up AHV in ledger-tool.
Fixes #31351