-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check program modification slots during cold start #31331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31331 +/- ##
========================================
Coverage 81.5% 81.5%
========================================
Files 734 734
Lines 207153 207288 +135
========================================
+ Hits 168955 169073 +118
- Misses 38198 38215 +17 |
pgarg66
force-pushed
the
deployment-slot-check
branch
3 times, most recently
from
April 25, 2023 23:02
c92b619
to
3ac804c
Compare
#31348 has been merged. could you try to rebase again? thank you for your patient! |
pgarg66
force-pushed
the
deployment-slot-check
branch
from
April 26, 2023 01:52
3ac804c
to
0045969
Compare
Lichtso
reviewed
Apr 26, 2023
Lichtso
reviewed
Apr 26, 2023
Lichtso
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During cold start, the program cache could have an incomplete view of the deployed/modified programs. The cache relies on program management instructions to update and manage program cache entries during regular run time. But, at the startup ledger may have modifications to the program that are not yet rooted (i.e. only valid on certain forks). This can lead to execution of an outdated program.
Summary of Changes
Fixes #