Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - Removes the CLI option "no-bpf-jit" #31329

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Apr 24, 2023

Problem

This option is useless in production and for debugging the validator is mostly build from sources. It is routed through the validator code via multiple obscure techniques such as registering multiple versions of the same built-in program. It should be removed because it stands in the way of unifying all built-in programs in one place.

Summary of Changes

  • Removes the CLI argument "no-bpf-jit".
  • Removes its plumbering through out the validator code base.
  • Removes the with_jit variants of the bpf_loader programs.
  • Removes the to_builtin!() macro.

@Lichtso Lichtso force-pushed the cleanup/jit_toggle_plumbering branch 2 times, most recently from 954a283 to db057de Compare April 24, 2023 22:11
@Lichtso Lichtso force-pushed the cleanup/jit_toggle_plumbering branch from db057de to 21f8196 Compare April 24, 2023 23:00
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #31329 (ae6ccf4) into master (4b0e16d) will increase coverage by 0.0%.
The diff coverage is 84.8%.

@@           Coverage Diff           @@
##           master   #31329   +/-   ##
=======================================
  Coverage    81.5%    81.5%           
=======================================
  Files         734      734           
  Lines      207159   207137   -22     
=======================================
+ Hits       168959   168972   +13     
+ Misses      38200    38165   -35     

@Lichtso Lichtso force-pushed the cleanup/jit_toggle_plumbering branch from f710cc2 to c52a945 Compare April 25, 2023 08:19
@Lichtso Lichtso force-pushed the cleanup/jit_toggle_plumbering branch 3 times, most recently from bb28ccb to 163b2b1 Compare April 25, 2023 11:37
@Lichtso Lichtso force-pushed the cleanup/jit_toggle_plumbering branch from 163b2b1 to ae6ccf4 Compare April 25, 2023 11:46
@Lichtso Lichtso requested a review from pgarg66 April 25, 2023 13:18
@Lichtso Lichtso merged commit 7002c56 into solana-labs:master Apr 25, 2023
@Lichtso Lichtso deleted the cleanup/jit_toggle_plumbering branch April 25, 2023 17:04
@dmakarov
Copy link
Contributor

Why was it necessary to remove no-bpf-jit option? Running rbpf-cli doesn't work on Mac M1/M2 without interpreted mode of execution.

@Lichtso
Copy link
Contributor Author

Lichtso commented Apr 26, 2023

The Interpreter is still the fallback which is automatically used when the JIT is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants