This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add entry notification service for geyser #31290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
entry-notif-service
branch
3 times, most recently
from
b24a71a to
4cd8b61
Compare
Codecov Report
@@ Coverage Diff @@
## master #31290 +/- ##
=========================================
+ Coverage 81.3% 81.4% +0.1%
=========================================
Files 733 732 -1
Lines 204786 208809 +4023
=========================================
+ Hits 166517 170041 +3524
- Misses 38269 38768 +499 |
lijunwangs
reviewed
Apr 22, 2023
CriesofCarrots
force-pushed
the
entry-notif-service
branch
from
4cd8b61 to
dcece1f
Compare
CriesofCarrots
force-pushed
the
entry-notif-service
branch
from
dcece1f to
19a1fd9
Compare
|
Rebased to pick up CI fixes |
CriesofCarrots
force-pushed
the
entry-notif-service
branch
2 times, most recently
from
b299ec2 to
08dc6c2
Compare
CriesofCarrots
force-pushed
the
entry-notif-service
branch
from
08dc6c2 to
0cb91d9
Compare
carllin
reviewed
May 3, 2023
carllin
approved these changes
May 10, 2023
added 7 commits
May 10, 2023 16:29
CriesofCarrots
force-pushed
the
entry-notif-service
branch
from
5500c4a to
0e71d14
Compare
carllin
approved these changes
May 10, 2023
This was referenced May 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#30910 added gesyer-plugin-manager support for entry notifications, but
notify_entry()isn't actually called anywhere yet.Summary of Changes
Add service thread that takes messages from a channel and sends Entry notifications via geyser, only when a geyser plugin supports notifying entries.
Notifications are still not actually being sent, because nothing is sending messages to the channel. But this PR makes the initial plumbing of the EntryNotifierSender into the Tvu and Tpu. Separate PRs will implement notifier sends from each of these code paths.