Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Moves the system program into its own crate #31244

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Apr 18, 2023

Problem

Currently the system program is the only built-in which lives in the runtime crate and not in the programs directory like all other programs do. This causes problems with cyclic dependencies which have to be removed for #31221.

Summary of Changes

Moves the system program into its own crate in "programs/system"

@Lichtso Lichtso force-pushed the refactor/move_system_program_into_its_own_crate branch 4 times, most recently from 4aceea0 to 99c9b5a Compare April 18, 2023 17:24
@Lichtso Lichtso force-pushed the refactor/move_system_program_into_its_own_crate branch from 99c9b5a to 71c88fe Compare April 18, 2023 17:34
@Lichtso Lichtso requested a review from pgarg66 April 18, 2023 18:21
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #31244 (71c88fe) into master (f5fe260) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #31244   +/-   ##
=======================================
  Coverage    81.5%    81.5%           
=======================================
  Files         729      730    +1     
  Lines      206621   206617    -4     
=======================================
+ Hits       168484   168523   +39     
+ Misses      38137    38094   -43     

@Lichtso Lichtso merged commit 8162358 into solana-labs:master Apr 19, 2023
@Lichtso Lichtso deleted the refactor/move_system_program_into_its_own_crate branch April 19, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants