Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VerifyAccountsHashConfig private #31235

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Make VerifyAccountsHashConfig private #31235

merged 1 commit into from
Apr 18, 2023

Conversation

bw-solana
Copy link
Contributor

Problem

Bank has super wide public interface. Limiting this is helpful for looser coupling and future sub-moduling of bank.rs

Summary of Changes

  • Make VerifyAccountsHashConfig and verify_accounts_hash private to bank
  • Move fn run_final_hash_calc into bank

@bw-solana bw-solana marked this pull request as ready for review April 18, 2023 00:17
@bw-solana bw-solana requested a review from steviez April 18, 2023 00:17
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #31235 (1e3f904) into master (8fccbad) will increase coverage by 0.0%.
The diff coverage is 10.0%.

@@           Coverage Diff           @@
##           master   #31235   +/-   ##
=======================================
  Coverage    81.5%    81.5%           
=======================================
  Files         729      729           
  Lines      206470   206469    -1     
=======================================
+ Hits       168356   168371   +15     
+ Misses      38114    38098   -16

steviez
steviez approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@bw-solana bw-solana merged commit f5fe260 into solana-labs:master Apr 18, 2023
@bw-solana bw-solana deleted the bank_limit_visibility branch April 18, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviez steviez steviez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bw-solana @steviez