Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up stage exit handling #3122

Merged
merged 6 commits into from
Mar 5, 2019
Merged

Clean up stage exit handling #3122

merged 6 commits into from
Mar 5, 2019

Conversation

mvines
Copy link
Member

@mvines mvines commented Mar 5, 2019

  • Uniformly pass the exit signal as a reference, defer cloning until actually needed (ie, a new thread is spawned)
  • Remove a lot of the exit()'/close()` function copy pasta. Most stages don't need 2-3 ways to exit
  • Scrapped away a bit of dead code as a result of the previous two items

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Mar 5, 2019
@solana-grimes solana-grimes merged commit 6ab6e6c into solana-labs:master Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #3122 into master will increase coverage by <.1%.
The diff coverage is 89.8%.

@@           Coverage Diff            @@
##           master   #3122     +/-   ##
========================================
+ Coverage    78.7%   78.7%   +<.1%     
========================================
  Files         134     134             
  Lines       20075   19942    -133     
========================================
- Hits        15800   15704     -96     
+ Misses       4275    4238     -37

1 similar comment
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #3122 into master will increase coverage by <.1%.
The diff coverage is 89.8%.

@@           Coverage Diff            @@
##           master   #3122     +/-   ##
========================================
+ Coverage    78.7%   78.7%   +<.1%     
========================================
  Files         134     134             
  Lines       20075   19942    -133     
========================================
- Hits        15800   15704     -96     
+ Misses       4275    4238     -37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants