Add a filter_by_type param for purge_old_bank_snapshots #31191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Debating if I should add test function for purge_old_bank_snapshots or it would be an overkill. |
Codecov Report
@@ Coverage Diff @@
## master #31191 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 729 729
Lines 206560 206580 +20
=======================================
+ Hits 168402 168441 +39
+ Misses 38158 38139 -19 |
brooksprumo
reviewed
Apr 14, 2023
brooksprumo
reviewed
Apr 14, 2023
xiangzhu70
changed the title
apfitzge
reviewed
Apr 14, 2023
xiangzhu70
force-pushed
the
purge_pre_state_snapshot_dirs
branch
from
27dce4d to
e47b196
Compare
|
Adding test_purge_old_bank_snapshots() |
brooksprumo
reviewed
Apr 15, 2023
|
Created a function create_snapshot_dirs_for_tests to refactor the common code for creating test snapshot dirs in any numbers of PRE or POST states. |
xiangzhu70
force-pushed
the
purge_pre_state_snapshot_dirs
branch
from
914ce95 to
877553a
Compare
apfitzge
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #30978, we need more refined control of the snapshot dir purging behavior.
Before booting, we want to purge all PRE snapshot dirs.
During run time, we should purge only the POST snapshot dirs, letting AHV to process PRE snapshot dirs into POST.
Summary of Changes
Add the filter_by_type param. Call purging by type.
Fixes #