Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment in SolanaGossipMananger::update_latest_full_snapshot_hash() #31171

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

In a previous PR, I had added a github comment about some of the code. It was requested to put the comment into the code too. Original comment: #31154 (comment).

Summary of Changes

Add the comment.

Copy link
Contributor

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brooksprumo brooksprumo marked this pull request as ready for review April 12, 2023 15:15
@brooksprumo brooksprumo added the automerge Merge this Pull Request automatically once CI passes label Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #31171 (0cabfb4) into master (7f7351d) will decrease coverage by 0.1%.
The diff coverage is 47.4%.

@@            Coverage Diff            @@
##           master   #31171     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         729      729             
  Lines      206246   206287     +41     
=========================================
+ Hits       168262   168265      +3     
- Misses      37984    38022     +38     

@mergify mergify bot merged commit 602297e into solana-labs:master Apr 12, 2023
@brooksprumo brooksprumo deleted the snapshot-gossip/sgm-comment branch April 12, 2023 17:07
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants