disk index: move capacity to contents #31040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31040 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 728 728
Lines 205737 205751 +14
=======================================
+ Hits 167695 167719 +24
+ Misses 38042 38032 -10 |
brooksprumo
reviewed
Apr 4, 2023
| @@ -14,7 +14,17 @@ use { | |||
|
|
|||
| /// allocated in `contents` in a BucketStorage | |||
| pub struct BucketWithBitVec { | |||
| pub occupied: BitVec, | |||
| occupied: BitVec, | |||
| capacity_pow2: Capacity, | |||
There was a problem hiding this comment.
nit: Can this field be just capacity?
Suggested change
| capacity_pow2: Capacity, | |
| capacity: Capacity, |
There was a problem hiding this comment.
It could, but soon I will distinguish them as this one has to be pow2 because it will only be data bucket. So, to make it clear what it needed to represent, I decided to leave it named the same.
brooksprumo
previously approved these changes
Apr 4, 2023
|
merge conflicts caused a force push. Sorry. |
brooksprumo
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #30711
Summary of Changes
Move capacity to
contentswithin each disk bucket. This allows data and index buckets to have different algorithms for growth.Fixes #