Uses impl_crds_entry! for SnapshotHashes #31032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
snapshot-gossip/snapshot-hashes-crds-entry
branch
from
0e37b57 to
0fac443
Compare
Codecov Report
@@ Coverage Diff @@
## master #31032 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 728 728
Lines 205583 205578 -5
=========================================
- Hits 167711 167678 -33
- Misses 37872 37900 +28 |
behzadnouri
approved these changes
Apr 4, 2023
| impl_crds_entry!( | ||
| IncrementalSnapshotHashes, | ||
| CrdsData::IncrementalSnapshotHashes(incremental_snapshot_hashes), | ||
| incremental_snapshot_hashes | ||
| ); | ||
|
|
||
| impl<'a, 'b> CrdsEntry<'a, 'b> for &'a SnapshotHashes { |
There was a problem hiding this comment.
This manual implementation was because up until #20421, this was called SnapshotHash vs SnapshotHashes; so the existing macro wouldn't work here.
There was a problem hiding this comment.
Thanks for the link and context 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The manual implementation of
get_entry()forSnapshotHashescan be replaced byimpl_crds_entry!. Since it currently isn't, I end up rereading the impl to understand how the manual and macro impls are different, only to learn they are not different.Summary of Changes
Use
impl_crds_entry!to implementget_entry()forSnapshotHashes.