disk index: refactor OccupiedEnumTag #31028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
approved these changes
Apr 3, 2023
| @@ -286,7 +301,7 @@ impl<T: Copy> IndexEntryPlaceInBucket<T> { | |||
| index_entry.packed_ref_count.ref_count() | |||
| } | |||
|
|
|||
| pub fn read_value<'a>( | |||
| pub(crate) fn read_value<'a>( | |||
There was a problem hiding this comment.
Looks like this change snuck into this PR accidentally.
There was a problem hiding this comment.
no I Just left it here because it is a generally good thing.
Codecov Report
@@ Coverage Diff @@
## master #31028 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 728 728
Lines 205532 205536 +4
=======================================
+ Hits 167629 167648 +19
+ Misses 37903 37888 -15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #30711
enum tag is stored separately from enum values in the disk index.
Summary of Changes
Create an enum of the values themselves for safety, clarity, and easier refactoring.
Fixes #